Feature/reporters object model fix #589

pesse · 2018-02-14T08:56:38Z

This will break cli and java-api
Don't merge before utPLSQL/utPLSQL-java-api#45 is finished (I'm actually working on it)

ut_output_buffer is now fully abstracted from caller and caller can…

… use reporter to get the output data.

Introduced new abstract type: ut_output_reporter_base.
Every reporter based on that type is supposed to use output buffer.
So for every reporter of type ut_output_reporter_base, client can call functions:

get_lines
lines_to_dbms_output
get_lines_cursor

Also, the reporters don't need to call parent reporter's method to finalize the reporting.
New finalize event is added.
There is no direct dependency between ut_runner.run and ut_output_buffer so we may now pass a reporter that doesn't report to output but saves data to table for example.

Removed unused code. Added unit tests for better coverage.

Refactored ut_output_buffer package into ut_output_table_buffer type.
Created base type for output_buffers.
Created header table for table output data.
Updated ut_output_reporter_base to contain by default ut_output_table_buffer
Updated tests for output buffers.
Refreshed list of sources for RunAll script.

Addressed review comments and fixed tests stability.

Removing initialization from output constructor

Fixed buffer initialization.

Fixed tests location after rebase.

… use reporter to get the output data. Introduced new abstract type: `ut_output_reporter_base`. Every reporter based on that type is supposed to use output buffer. So for every reporter of type `ut_output_reporter_base`, client can call functions: - get_lines - lines_to_dbms_output - get_lines_cursor Also, the reporters don't need to call parent reporter's method to finalize the reporting. New finalize event is added. There is no direct dependency between `ut_runner.run` and `ut_output_buffer` so we may now pass a reporter that doesn't report to output but saves data to table for example. Removed unused code. Added unit tests for better coverage. Refactored `ut_output_buffer` package into `ut_output_table_buffer` type. Created base type for output_buffers. Created header table for table output data. Updated `ut_output_reporter_base` to contain by default `ut_output_table_buffer` Updated tests for output buffers. Refreshed list of sources for RunAll script. Addressed review comments and fixed tests stability. Removing initialization from output constructor Fixed buffer initialization. Fixed tests location after rebase.

# Conflicts: # examples/demo_of_expectations/demo_equal_matcher.sql # old_tests/RunAll.sql # old_tests/ut_expectations/ut.expect.to_equal.cursor.SupportsSQLandPLSQLdatatypes.sql # old_tests/ut_output_buffer/send_line.DoesNotSendLineIfNullReporterIdGiven.sql # source/api/ut.pkb # source/api/ut_runner.pkb # source/core/output_buffers/ut_output_buffer_tmp.sql # source/core/ut_output_buffer.pkb # source/core/ut_output_buffer.pks # source/reporters/ut_documentation_reporter.tpb

jgebal · 2018-02-14T10:52:09Z

Let me know when you're good to go on java

This is for we need to re-instantiate the Output-Buffer from java-api. If we provide an output_id it should just "append" to the existing output-buffer.

This reverts commit 8fefdcf

whether a reporter has an output to buffer or not. The way with types is too cumbersome from java side

…s_object_model_fix

This reverts commit b4ece73

This reverts commit 83e4b0b

pesse · 2018-02-28T13:11:22Z

Closes #592

pesse · 2018-02-28T13:17:36Z

Closes #391

jgebal · 2018-03-01T09:20:06Z

This PR will break java-api, so we cannot merge it until changes are implemented on java side.

The list should return all known Reporters and information about whether the reporter is an output reporter or not

With that addition to every reporter implementation we can easily create documentation or help-functions for consuming applications like cli. We also encourage third party reporter-providers to give a description about their reporter.

…s_object_model_fix

jgebal

I like the description of reporter implemented in the reporter itself - neat!

jgebal · 2018-03-05T21:57:24Z

old_tests/RunAll.sql

@@ -72,7 +72,8 @@ exec ut_coverage.coverage_start_develop();
 @@lib/RunTest.sql ut_metadata/ut_metadata.form_name.TrimStandaloneProgramName.sql

 @@lib/RunTest.sql ut_output_buffer/get_lines.RecievesALineFromBufferTableAndDeletes.sql
-@@lib/RunTest.sql ut_output_buffer/send_line.DoesNotSendLineIfNullReporterIdGiven.sql
+@@lib/RunTest.sql ut_output_buffer/get_lines.WaitsForMoreDataToAppearForSpecifiedTime.sql


The work on this PR was initially started before switch to self-testing.
Would you be able to rewrite some of those tests to use new formula (utPLSQL v3 self-testing)?

I'll try to, but will work on java-api before. That's something we can change after 3.1.0 as part of refactoring, can't we?

jgebal · 2018-03-05T22:02:46Z

source/reporters/ut_coverage_sonar_reporter.tpb

+  overriding member function get_description return varchar2 as
+  begin
+    return 'Generates a JSON coverage report providing information on code coverage with line numbers.' || chr(10) ||
+           'Designed for [SonarQube](https://about.sonarqube.com/) to report coverage.';


I would add line:
JSON format returned conforms with the Sonar specification: https://docs.sonarqube.org/display/SONAR/Generic+Test+Data

jgebal · 2018-03-05T22:05:30Z

source/reporters/ut_coveralls_reporter.tpb

+  overriding member function get_description return varchar2 as
+  begin
+    return 'Generates a JSON coverage report providing information on code coverage with line numbers.' || chr(10) ||
+           'Designed for [Coveralls](https://coveralls.io/).';


I would add link:
JSON format conforms with specification: https://docs.coveralls.io/api-introduction

jgebal · 2018-03-05T22:05:56Z

source/reporters/ut_sonar_test_reporter.tpb

@@ -97,5 +97,11 @@ create or replace type body ut_sonar_test_reporter is
    self.print_text('</testExecutions>');
  end;

+  overriding member function get_description return varchar2 as
+  begin
+    return 'Generates a JSON report providing detailed information on test execution.' || chr(10) ||


I would add line:
JSON format returned conforms with the Sonar specification: https://docs.sonarqube.org/display/SONAR/Generic+Test+Data

jgebal · 2018-03-05T22:07:00Z

source/reporters/ut_teamcity_reporter.tpb

@@ -113,5 +113,10 @@ create or replace type body ut_teamcity_reporter is

  end;

+  overriding member function get_description return varchar2 as
+  begin
+    return 'For reporting live progress of test execution with Teamcity CI.';


As described in documentation: https://confluence.jetbrains.com/display/TCD9/Build+Script+Interaction+with+TeamCity

jgebal · 2018-03-05T22:08:03Z

source/reporters/ut_xunit_reporter.tpb

@@ -130,5 +129,10 @@ create or replace type body ut_xunit_reporter is
           || '" time="' || ut_utils.to_xml_number_format(a_item.execution_time()) || '" ';
  end;

+  overriding member function get_description return varchar2 as
+  begin
+    return 'Used for reporting test results with CI servers like Jenkins/Hudson/Teamcity.';


Provides outcomes in a format conforming with JUnit 4 and above as defined in: https://gist.github.com/kuzuha/232902acab1344d6b578

jgebal · 2018-03-05T22:09:05Z

tests/ut_expectations/ut.expect.not_to_equal.anydata.GivesFailureWhenComparingTheSameData.sql

@@ -0,0 +1,17 @@
+--Arrange


Those tests should be moved to utPLSQL v3 test pacakges.

…s_object_model_fix

jgebal and others added 5 commits October 18, 2017 00:11

Fixed some merge issues

a9031f4

We should keep installing ut_message_id_seq I guess...

19ac972

Fixed output buffer and related test.

43b8754

pesse requested review from jgebal and Pazus February 14, 2018 08:56

pesse mentioned this pull request Feb 14, 2018

Feature/refactor reporter api utPLSQL/utPLSQL-java-api#45

Merged

Version number to 3 instead of X.X.X.X

7fde523

jgebal approved these changes Feb 14, 2018

View reviewed changes

Output-Buffer no longer deletes contents during init

b8dc2a6

This is for we need to re-instantiate the Output-Buffer from java-api. If we provide an output_id it should just "append" to the existing output-buffer.

pesse added the in progress label Feb 21, 2018

pesse added 7 commits February 22, 2018 22:02

Added ut_output_reporter_base to synonyms and grants

8fefdcf

Revert "Added ut_output_reporter_base to synonyms and grants"

83e4b0b

This reverts commit 8fefdcf

Added new member-function has_output to easily check

b4ece73

whether a reporter has an output to buffer or not. The way with types is too cumbersome from java side

Merge remote-tracking branch 'upstream/develop' into feature/reporter…

94b7ea1

…s_object_model_fix

Revert "Added new member-function has_output to easily check"

d792fec

This reverts commit b4ece73

Reapply "Added ut_output_reporter_base to synonyms and grants""

202e697

This reverts commit 83e4b0b

Add function to check whether a given name is a valid output reporter

bfde057

pesse mentioned this pull request Feb 28, 2018

"Stored in Table" customer reporter #535

Closed

jgebal added this to the v3.1.0 milestone Mar 1, 2018

pesse added 5 commits March 4, 2018 14:28

Replace is_output_reporter by get_reporters_list

92f7b4c

The list should return all known Reporters and information about whether the reporter is an output reporter or not

Added description to all reporters

5272342

With that addition to every reporter implementation we can easily create documentation or help-functions for consuming applications like cli. We also encourage third party reporter-providers to give a description about their reporter.

Unit-Test for get_reporters_list

7b34109

Fix get_reporters_list unit-test

aae83f2

Merge remote-tracking branch 'upstream/develop' into feature/reporter…

014981c

…s_object_model_fix

We have a Cobertura-Reporter now, too

4488415

jgebal reviewed Mar 5, 2018

View reviewed changes

pesse and others added 6 commits March 6, 2018 09:21

Improved reporter-description according to jgebal's suggestions

762727b

Bump version to 3.1.0

7e428a1

Merge remote-tracking branch 'upstream/develop' into feature/reporter…

a466609

…s_object_model_fix

Added Cobertura Description

c0df23d

Added Cobertura Description

cdacf29

Merge remote-tracking branch 'upstream/develop' into feature/reporter…

9504d1b

…s_object_model_fix

pesse merged commit d3b034d into develop Mar 8, 2018

pesse mentioned this pull request Mar 8, 2018

How to populate Unit test results in the tables #541

Closed

jgebal mentioned this pull request Mar 16, 2018

Abstract outputbuffer from a reporter class #391

Closed

jgebal deleted the feature/reporters_object_model_fix branch March 27, 2018 11:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/reporters object model fix #589

Feature/reporters object model fix #589

Uh oh!

pesse commented Feb 14, 2018

Uh oh!

jgebal commented Feb 14, 2018

Uh oh!

pesse commented Feb 28, 2018

Uh oh!

pesse commented Feb 28, 2018

Uh oh!

jgebal commented Mar 1, 2018

Uh oh!

jgebal left a comment

Uh oh!

jgebal Mar 5, 2018

Uh oh!

pesse Mar 6, 2018

Uh oh!

jgebal Mar 5, 2018

Uh oh!

jgebal Mar 5, 2018

Uh oh!

jgebal Mar 5, 2018

Uh oh!

jgebal Mar 5, 2018

Uh oh!

jgebal Mar 5, 2018

Uh oh!

jgebal Mar 5, 2018

Uh oh!

Uh oh!

Feature/reporters object model fix #589

Feature/reporters object model fix #589

Uh oh!

Conversation

pesse commented Feb 14, 2018

Uh oh!

jgebal commented Feb 14, 2018

Uh oh!

pesse commented Feb 28, 2018

Uh oh!

pesse commented Feb 28, 2018

Uh oh!

jgebal commented Mar 1, 2018

Uh oh!

jgebal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!