Skip to content

Feature/cursor implicit #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 22, 2018
Merged

Feature/cursor implicit #648

merged 6 commits into from
Apr 22, 2018

Conversation

lwasylow
Copy link
Member

Implement fix for xml parsing when cursor column missing alias. Fixes #632
This will not include changes to include and exclude options as this will require syntax checking with xpath and possible rework way options are passed

@jgebal
Copy link
Member

jgebal commented Apr 22, 2018

Just to be clear.
With this change, we allow for comparison of columns with implicit names, however, we do not support implicit column names in the include/exclude filters.
Is that right?

@lwasylow
Copy link
Member Author

That's correct, I have tested filters and problem is that there is no clear distinct between a column name in filter or xpath expression. E. G. ('Test', '\/test') without knowing these we would ass that second value is a special name for column where in fact was invalid xpath.

@jgebal
Copy link
Member

jgebal commented Apr 22, 2018

Can you add a note to advanced_data_comparison.md to inform that exclude/include does not support columns with implicit names?
We could also add a test to prove that it's not working - as an expected behavior.

The test should document, what happens today if we use the exclude() with implicit column name.

@lwasylow
Copy link
Member Author

Of course 👍

@jgebal jgebal added this to the v3.1.0 milestone Apr 22, 2018
@jgebal jgebal merged commit e99abf1 into develop Apr 22, 2018
@jgebal jgebal deleted the feature/cursor_implicit branch April 22, 2018 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursors Comparision, lack of colum aliases results in XML parsing error.
3 participants