Skip to content

Fixed the errors with timestamp in tests #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2018
Merged

Fixed the errors with timestamp in tests #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5f33c1
Fixed the errors with timestamp in tests
AlexisGaldamez May 7, 2018
83f2792
Merge branch 'develop' into fixed_timestamp_error
jgebal May 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions old_tests/ut_output_buffer/get_lines.WaitsForMoreDataToAppearForSpecifiedTime.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ declare
l_result integer;
l_dummy integer;
l_output ut_output_buffer_base := ut_output_table_buffer();
l_start_time timestamp := systimestamp;
l_start_time timestamp := localtimestamp;
l_wait_seconds integer := 1;
begin
--Act
l_output.send_line(lpad('a text',4000,',a text'));

select count(*) into l_dummy from table( l_output.get_lines( a_initial_timeout => 0, a_timeout_sec => l_wait_seconds ));
l_result := round(extract(second from (systimestamp - l_start_time)));
l_result := round(extract(second from (localtimestamp - l_start_time)));

--Assert
ut.expect(l_result).to_equal(l_wait_seconds);
Expand Down
4 changes: 2 additions & 2 deletions old_tests/ut_output_buffer/get_lines.WaitsForTheDataToAppearForSpecifiedTime.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ declare
l_result integer;
l_dummy integer;
l_output ut_output_buffer_base := ut_output_table_buffer();
l_start_time timestamp := systimestamp;
l_start_time timestamp := localtimestamp;
l_wait_seconds integer := 1;
begin
--Act
select count(1) into l_dummy from table( l_output.get_lines( a_initial_timeout => l_wait_seconds, a_timeout_sec => 0 ));
l_result := round(extract(second from (systimestamp - l_start_time)));
l_result := round(extract(second from (localtimestamp - l_start_time)));

--Assert
ut.expect(l_result).to_equal(l_wait_seconds);
Expand Down
3 changes: 2 additions & 1 deletion test/api/test_ut_run.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ create or replace package body test_ut_run is
g_state varchar2(3) := 'abc';
end;]';
end;/',
start_date => sysdate,
start_date => localtimestamp,
enabled => TRUE,
auto_drop => TRUE,
comments => 'one-time job'
Expand Down Expand Up @@ -98,6 +98,7 @@ Failures:%

--Act
select * bulk collect into l_results from table(ut3.ut.run('test_stateful'));

--Assert
ut.fail('Expected exception but nothing was raised');
exception
Expand Down
4 changes: 2 additions & 2 deletions test/core/test_output_buffer.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ create or replace package body test_output_buffer is
--Act
l_expected := lpad('a text',4000,',a text');
l_buffer.send_line(l_expected);
l_start := systimestamp;
l_start := localtimestamp;
select * into l_result from table(l_buffer.get_lines(1,1));
l_duration := systimestamp - l_start;
l_duration := localtimestamp - l_start;

ut.expect(l_result).to_equal(l_expected);
ut.expect(l_duration).to_be_greater_than(interval '1' second);
Expand Down