Added Support to pass comma delimited list of test names #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgebal
requested changes
Jul 14, 2018
test/api/test_ut_run.pks
Outdated
| @@ -22,6 +22,29 @@ create or replace package test_ut_run is | |||
| procedure run_and_revalidate_specs; | |||
| procedure generate_invalid_spec; | |||
| procedure drop_test_package; | |||
|
|
|||
| procedure create_test_csl_packages; | |||
There was a problem hiding this comment.
Can you make it a context and use beforeall / afterall inside context?
That way the package will get created/dropped only once.
test/api/test_ut_run.pkb
Outdated
| begin | ||
| select * | ||
| bulk collect into l_results | ||
| from table(ut3.ut.run('test_csl_names1,test_csl_names2')); |
There was a problem hiding this comment.
Can you add spaces / tabs instde the text to validate that it still works?
test/api/test_ut_run.pkb
Outdated
| @@ -202,6 +202,130 @@ end;]'; | |||
| begin | |||
| execute immediate 'drop package invalid_pckag_that_revalidates'; | |||
| execute immediate 'drop package parent_specs'; | |||
| end; | |||
|
|
|||
There was a problem hiding this comment.
Can you cover all 3 changed entry points (procedures) with tests so we have regression for each of them?
|
We should move the logic chane to ut_runner and convert each element of |
|
I have updated tests, moved decomposing of coma separated list into ut_runner and updated docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option of using a coma separated string of test names.
Fixes #479