-
Notifications
You must be signed in to change notification settings - Fork 185
Adding suite check API & performance improvements #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…he infamous ORA-00600 `ORA-00600: internal error code, arguments: [pfrobj.c: invalid RTTI for Object], [], [], [], [], [], [], [], [], [], [], []``
Refactored lots of code for suite parsing/building. (Acceptance) tests need rework due to changes in test execution ordering.
One problem to be solved. Oracle nested tables are **unordered!** and we need an ordered list of before/after items that contain CLOB column, so cannot be varray.
Added `seq_no`, numbering before storage and sorting after retrieval.
Added static schema name rather than bind variable.
Adding new function to return list of suites and tests.
Changed functions to procedures to avoid copying of large memmory segments.
This reverts commit 3543e3d
…ormation based on info suite cache. Suite cache is refreshed when calling procedure (as needed).
…s not used uin prior versions. Added functions `is_test`, `is_suite`, `has_suite` to perform checks for test/suite existance at prcedure, package, schema level.
The script will now automatically copy `*.jar` files into `/utPLSQL-cli/lib` directory.
Fixed failing test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 6
Including the following issue(s) which could not be reported in line:
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: The procedure "run" should be refactored to take at most 10 parameters instead of 11 as currently. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 6
Including the following issue(s) which could not be reported in line:
Code Smell: The procedure "run" should be refactored to take at most 10 parameters instead of 11 as currently. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 6
Including the following issue(s) which could not be reported in line:
Code Smell: The procedure "run" should be refactored to take at most 10 parameters instead of 11 as currently. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 6
Including the following issue(s) which could not be reported in line:
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: The procedure "run" should be refactored to take at most 10 parameters instead of 11 as currently. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Added default value for owner, when calling `get_suites_info`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 5
Including the following issue(s) which could not be reported in line:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 5
Including the following issue(s) which could not be reported in line:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 5
Including the following issue(s) which could not be reported in line:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 5
Including the following issue(s) which could not be reported in line:
Added additional tests to: - cover functionality of reporting warnings on transaction invalidation with sub-suites. - cover functionality of failing a test in sub-suite when beforeall fails in parent suite with logical suites in between. Refactored `ut_teamcity_reporter` a bit.
26eb3ca
to
74ec9a1
Compare
Disabled coverage gathering on old tests.
Fixed issue with warnings not getting shown.
ut_runner
get_suites_info
- resolves Add ability to retrieve information abut test suites #785is_test
- resolves Add ability to check if procedure is a test #788is_suite
- resolves Ability to check if package is a test suite #787has_suites
- resolves Add ability to check if schema has suites #786Added suite level cache as a complementary cache on top of annotations cache.
Improved performance of suite-builder by using IN OUT NOCOPY and avoiding large data variable copying/assignments.
Minimized the amount of data scanned after package compilation.
We now join to
all_objects
only when executing user doesn't have execute any and is not owner of test packages.Resolves #778
Reworked output buffer and reporters for performance (we now do bulk inserts into buffer where applicable) - resolves #777