Bugfix/class not found jaxb #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #85. Also added a multi-reporter integration-test
jgebal
reviewed
May 19, 2018
| @@ -145,6 +144,9 @@ public int run() throws Exception { | |||
| final ArrayList<String> finalIncludeObjectsList = includeObjectsList; | |||
| final ArrayList<String> finalExcludeObjectsList = excludeObjectsList; | |||
|
|
|||
| final ConnectionInfo ci = getConnectionInfo(); | |||
| ci.setMaxConnections(getReporterManager().getNumberOfReporters()+1); | |||
There was a problem hiding this comment.
Because we need a separate connection for TestRunner to start. The Reporters are all in their own threads and due to concurrency it's always preferrable to have a separate connection for each thread.
Main thread: TestRunner
Thread 1: Reporter 1
Thread 2: Reporter 2
etc.
jgebal
approved these changes
May 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
Fixes #80
Fixes #85