Cleanup base on IDEA Code Inspector and small refactoring #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… simplified if statements etc) based on IDEA code inspector Refactored creation of ReporterInspectors. Made them immutable, separated creation from ReporterInfo collection fill Made TestRunnerStatement AutoClosable to be used with try-with-resource For SQLData implementations (FileMapping, KeyValuePair) made setters private
added private constructors to pure utility static classes Refactored Version class to be immutable
refactored ReportInspectors: moved Map creation to interface default method, moved info storage and initialization to subclasses from abstract class. Fixed test failure due to wrong order of construction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial cleanup (remove unnecessary imports, making properties final, simplified if statements etc) based on IDEA code inspector
Refactored creation of ReporterInspectors. Made them immutable, separated creation from ReporterInfo collection fill
Made TestRunnerStatement AutoClosable to be used with try-with-resource
For SQLData implementations (FileMapping, KeyValuePair) made setters private