Skip to content

excludeObject and includeObject doesn't work for multiple values #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Gepar opened this issue Nov 29, 2021 · 7 comments
Closed

excludeObject and includeObject doesn't work for multiple values #62

Gepar opened this issue Nov 29, 2021 · 7 comments
Assignees
@simasch
Labels
bug
Milestone
3.1.7

Comments

@Gepar
Copy link

Gepar commented Nov 29, 2021

According to documentation we can do this:
<excludeObject>app.test1,app.test2</excludeObject>
But according to maven plugin sources we can pass only one parameter because string is passing without split by any delimiter

                if (isNotBlank(excludeObject)) {
                    runner.excludeObject(excludeObject);
                }
@simasch simasch self-assigned this Dec 2, 2021
@simasch simasch added the bug label Dec 2, 2021
@simasch
Copy link
Member

simasch commented Dec 2, 2021

Thank you for reporting the issue @Gepar

I'll create a bugfix release in the next few days

@simasch
Copy link
Member

simasch commented Dec 3, 2021

Also includeObject has the same issue

@simasch simasch changed the title excludeObject doesn't work for multiple values excludeObject and includeObject doesn't work for multiple values Dec 3, 2021
simasch added a commit that referenced this issue Dec 3, 2021
@simasch
#62 excludeObject and includeObject doesn't work for multiple values
e39f177
@simasch simasch added this to the 3.1.7 milestone Dec 3, 2021
@simasch simasch closed this as completed Dec 3, 2021
@diamond54321
Copy link

@simasch, it seams there is a bug in your commit:

if (isNotBlank(includeObject)) {
                    if (includeObject.contains(",")) {
                        String[] includes = includeObject.split(",");
                        runner.excludeObjects(Arrays.asList(includes));
                    } else {
                        runner.excludeObject(includeObject);
                    }
                }

includeObject goes to runner.excludeObject now

@simasch
Copy link
Member

simasch commented Dec 14, 2021

Hi @diamond54321 Thanks a lot for the your bug report.
I'll go ahead and fix this asap

@simasch
Copy link
Member

simasch commented Dec 14, 2021

Added a new issue for this: #64

@simasch
Copy link
Member

simasch commented Dec 14, 2021

@diamond54321 a new release 3.1.9 with the fix has been released

@diamond54321
Copy link

@simasch thanks a lot for the rapid fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simasch simasch

Labels
bug
Projects
None yet
Milestone
3.1.7
Development

No branches or pull requests
3 participants
@simasch @Gepar @diamond54321