travis: switch to Bionic #1075
Merged
travis: switch to Bionic #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To judge from fc412fe, back in 2016 it was the latest version of Ubuntu available on Travis CI. Now build tools there are too old for testing purposes. Other than that, Ubuntu Trusty hasn't been supported at https://apt.llvm.org/ since August 2019, which makes it kind of hard at this point to bring the latest clang along with ASan, UBsan, Msan and libFuzzer to Travis CI.
8f9eb0f to
3a695fa
Compare
to get around an ASan bug mentioned in util-linux#1076
to prepare the infrastructure for util-linux#1068
|
It seems to be working now. Tomorrow hopefully I'll replace the hard-coded values to make it easier to switch to the next version of clang/gcc once they're available. |
|
OK, I'll wait for the update. |
by just changing the compiler option in .travis.yml In https://travis-ci.org/github/karelzak/util-linux/builds/703664282 I switched to gcc-9/clang-9 by simply applying the following patch: ``` diff --git a/.travis.yml b/.travis.yml index ec12847..12a247d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,8 +7,8 @@ git: depth: 1500 compiler: - - gcc-10 - - clang-10 + - gcc-9 + - clang-9 env: - MAKE_CHECK="nonroot" ```
1e7f76a to
e0967c5
Compare
|
To judge from https://travis-ci.org/github/karelzak/util-linux/builds/703664282 where I switched from gcc-10/clang-10 to gcc-9/clang-9 by changing just the compiler option in diff --git a/.travis.yml b/.travis.yml
index ec1284717..12a247d91 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -7,8 +7,8 @@ git:
depth: 1500
compiler:
- - gcc-10
- - clang-10
+ - gcc-9
+ - clang-9
env:
- MAKE_CHECK="nonroot"I think it's safe to say that that part is more or less maintainable and the PR should be good to go. @karelzak could you take a look? |
|
By the way, trying to make sure I didn't break anything I looked for places where Is drone.io still used? If not, I can delete that in a follow-up PR so as not to confuse contributors. |
|
Merged, thanks! I have updated the Documentation/howto-tests.txt, drone.io seems dead thing -- I have added LGTM.com. |
evverx
added a commit
to evverx/util-linux
that referenced
this pull request
Jul 1, 2020
Backtraces like
```
misc-utils/cal.c:295:4: runtime error: signed integer overflow: 2147483647 + 5 cannot be represented in type 'int'
==1405==WARNING: invalid path to external symbolizer!
==1405==WARNING: Failed to use and restart external symbolizer!
#0 0x4c4c09 (/home/travis/build/karelzak/util-linux/cal+0x4c4c09)
#1 0x7f4363046b96 (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
#2 0x41bab9 (/home/travis/build/karelzak/util-linux/cal+0x41bab9)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior misc-utils/cal.c:295:4 in
```
aren't very helpful
It's follow-up to util-linux#1075
evverx
added a commit
to evverx/util-linux
that referenced
this pull request
Jul 1, 2020
Backtraces like
```
misc-utils/cal.c:295:4: runtime error: signed integer overflow: 2147483647 + 5 cannot be represented in type 'int'
==1405==WARNING: invalid path to external symbolizer!
==1405==WARNING: Failed to use and restart external symbolizer!
#0 0x4c4c09 (/home/travis/build/karelzak/util-linux/cal+0x4c4c09)
#1 0x7f4363046b96 (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
#2 0x41bab9 (/home/travis/build/karelzak/util-linux/cal+0x41bab9)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior misc-utils/cal.c:295:4 in
```
aren't very helpful
It's follow-up to util-linux#1075
evverx
added a commit
to evverx/util-linux
that referenced
this pull request
Jul 1, 2020
Backtraces like
```
misc-utils/cal.c:295:4: runtime error: signed integer overflow: 2147483647 + 5 cannot be represented in type 'int'
==1405==WARNING: invalid path to external symbolizer!
==1405==WARNING: Failed to use and restart external symbolizer!
#0 0x4c4c09 (/home/travis/build/karelzak/util-linux/cal+0x4c4c09)
#1 0x7f4363046b96 (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
#2 0x41bab9 (/home/travis/build/karelzak/util-linux/cal+0x41bab9)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior misc-utils/cal.c:295:4 in
```
aren't very helpful
It's follow-up to util-linux#1075
|
Ah, yesterday I get an email to re-activate drone.io ;-) It seems it works, but all the previous settings probably lost. I'll ignore it for now. |
karelzak
pushed a commit
that referenced
this pull request
Jul 3, 2020
Backtraces like
```
misc-utils/cal.c:295:4: runtime error: signed integer overflow: 2147483647 + 5 cannot be represented in type 'int'
==1405==WARNING: invalid path to external symbolizer!
==1405==WARNING: Failed to use and restart external symbolizer!
#0 0x4c4c09 (/home/travis/build/karelzak/util-linux/cal+0x4c4c09)
#1 0x7f4363046b96 (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
#2 0x41bab9 (/home/travis/build/karelzak/util-linux/cal+0x41bab9)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior misc-utils/cal.c:295:4 in
```
aren't very helpful
It's follow-up to #1075
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To judge from fc412fe, back in 2016 it was the latest version
of Ubuntu available on Travis CI. Now build tools there are too old
for testing purposes.
Other than that, Ubuntu Trusty hasn't been supported at https://apt.llvm.org/
since August 2019, which makes it kind of hard at this point to bring the latest clang
along with ASan, UBsan, Msan and libFuzzer to Travis CI.