lsns: minor refactoring #3006
Merged
lsns: minor refactoring #3006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions taking LSNS_ID_ as arguments have .*_lsns_type_.* or .*_type_.* as parts of their name. This implies the prefix LSNS_TYPE_ is more consistent than LSNS_ID_. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…umerators Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…rts of get_ns_ino() get_ns_ino() returns three inode numbers. The code for the two of three, inodes for PARENT and USERNS, is moved to the new functions. So we can reuse the code in other places in lsns. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…_nsfd Signed-off-by: Masatake YAMATO <yamato@redhat.com>
The function gets three inode numbers. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
read_related_namespaces() itself doesn't read names of new namespaces. Connecting namespaces for making a tree is the the main job the function. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…stent Signed-off-by: Masatake YAMATO <yamato@redhat.com>
In read_open_ns_inos(), a namespace is added to the list without verifying its uniqueness in the list. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
karelzak
reviewed
May 2, 2024
|
|
||
| *ino = 0; | ||
| if (ul_path_stat(pc, &st, 0, path) != 0) | ||
| return -errno; |
There was a problem hiding this comment.
It seems we need to add
ul_path_statf(struct path_cxt *pc, struct stat *sb, int flags, const char *path, ...)to lib/path.c to avoid snprintf() and the path[]. And then we can use ul_path_statf(PC, &st, 0, "ns/%s", nsname);
There was a problem hiding this comment.
Implemented (but not tested yet): #3007
There was a problem hiding this comment.
I chrry-pick'ed #3007 to this pull request.
There was a problem hiding this comment.
I'll apply the openf and statf to lsfd in another pull request.
|
Looks good, thanks! |
Signed-off-by: Karel Zak <kzak@redhat.com> (cherry picked from commit 9b47899)
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While inspecting #2982 and #2987, I found some areas where I could improve the readability of the source code.
Here is a figure I used during the inspection and refactoring.
