-
Notifications
You must be signed in to change notification settings - Fork 1.2k
DEBUG: fincore/count recursive debug #3551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
b8f6ce3
to
55661c7
Compare
Add a --recursive flag to fincore which allows to recursively scan directories. Co-authored-by: Karel Zak <kzak@redhat.com> Signed-off-by: Matteo Croce <teknoraver@meta.com>
9ad8ecb
to
3212a1b
Compare
strace has 'append-mode'. I guess it helps you.
|
I created an armv7 locally and here the output is:
While in the CI is:
The flags are respectively FTS_D and FTS_DP. |
3212a1b
to
d345b45
Compare
footer "$?" | ||
} >> $TS_OUTPUT 2>> $TS_ERRLOG | ||
|
||
if [ -n "$RECURSIVE" ]; then | ||
mkdir -p $TS_OUTDIR/i_dir | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using mkdir $(make_input_name "dir")
to keep the "i_" prefix only in make_incpur_name. You also do not need to use $TS_OUTDIR as it runs in the directory (see ts_cd).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will fix this in the original PR when I'll figure out what is the armv7 issue
} >> $TS_OUTPUT 2>> $TS_ERRLOG | ||
|
||
ts_log_both "[ RECURSIVE SCAN ]" | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add debug output with ls—la
for the directory to verify that the content is really there. It sounds strange, but sleeping/sync before the recursive call may help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the content is really there, I run find:
find i_dir -ls
348203 4 drwxr-xr-x 2 root root 4096 May 6 00:43 i_dir
348204 0 -rw-r--r-- 1 root root 0 May 6 00:43 i_dir/EMPTY_FILE
348206 4 -rw-r--r-- 1 root root 4096 May 6 00:43 i_dir/JUST_PAGESIZE_incore_
348205 4 -rw-r--r-- 1 root root 4095 May 6 00:43 i_dir/PAGESIZE_-1__incore_
and also fincore with a glob:
RUN: fincore --raw --output PAGES,SIZE,FILE --bytes --raw i_dir/*
PAGES SIZE FILE
0 0 i_dir/EMPTY_FILE
1 4096 i_dir/JUST_PAGESIZE_incore_
1 4095 i_dir/PAGESIZE_-1__incore_
END: EXIT 0
|
||
echo 'find i_dir -ls' | ||
find i_dir -ls | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. Sorry.
By the way, gnulib has a private FTS implementation that differs from glibc. https://github.com/coreutils/gnulib/blob/master/lib/fts.c |
I know, I faced it when doing the first |
No description provided.