-
Notifications
You must be signed in to change notification settings - Fork 1.3k
libblkid: Add scoutfs filesystem. #3596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update: Fixed unknown |
Update: Fixed printf specifiers. |
Hmm... we have a bad experience when the filesystem is detected only by a short magic string. It's better when it's possible to check something more from the header or superblock. For example, check some numbers for limits, etc. The ideal solution is a checksum, because it ensures we read the correct superblock. |
@karelzak yep, I changed it to validate the checksum. There are further checks we could to to validate the structure but those are going to be much more complicated than this. |
Update: Several changes:
|
Also is there some superblock indicator that distinguishes different devices inside a single filesystem? For example |
No. scoutfs always has a 1:1 pairing of meta/data devices. There is no further zoning or subdivision, either. |
0c1855a
to
eb0b56f
Compare
One additional update with hints, some spacing/whitespace/misc fixes, and removed double reading of the sb, and minsz (setting it to 1gb). |
Looks like CI can't fetch resources atm. |
The scoutfs filesystem is maintained out-of-tree, but current enough that we want to submit it for inclusion in libblkid - there's a few users out there that would benefit from being able to have lsblk aid in diagnosing and identifying. For more information about scoutfs, visit the github page here: https://github.com/versity/scoutfs Test images are provided for both data and meta devices. These were taken from validation samples. The wiper is set to only wipe a minute part of the filesystem - basically only the superblock. This is adequately destructive. Signed-off-by: Auke Kok <auke.kok@versity.com>
Update: rebased, few last requested changes. Test images updated to match minsz. |
The scoutfs filesystem is maintained out-of-tree, but current enough that we want to submit it for inclusion in libblkid - there's a few users out there that would benefit from being able to have lsblk aid in diagnosing and identifying.
For more information about scoutfs, visit the github page here:
https://github.com/versity/scoutfs