Skip to content

script: support non-option argument as command #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

script: support non-option argument as command #3599

wants to merge 1 commit into from

Conversation

echoechoin
Copy link
Contributor

fix #3481

github-advanced-security[bot]
github-advanced-security bot found potential problems May 29, 2025
View reviewed changes
@echoechoin echoechoin force-pushed the script_command branch 2 times, most recently from dc54492 to b6a3f96 Compare May 29, 2025 10:05
@karelzak
Copy link
Collaborator

Please, also update the man page (SYNOPSIS section) to reflect the change:

 script [options] [file] [ -- program [arguments]]

And maybe also add a note to '--command` that the user can use "--".

@karelzak
Copy link
Collaborator

karelzak commented Jun 2, 2025

@echoechoin please, see also my other comments above.

@echoechoin
Copy link
Contributor Author

Are there any other suggestions for modifications? I only saw one comment. If I understood correctly, I have implemented the following changes:

  1. modify the command format to script [options] [file] [ -- program [arguments]];
  2. update the man page accordingly to let user know they can use -- to specify command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple arguments for the script command without quoting
2 participants
@echoechoin @karelzak