Skip to content

"who --lookup" is failing on travis CI #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sylvestre opened this issue May 6, 2021 · 2 comments · Fixed by #2210
Closed

"who --lookup" is failing on travis CI #2181

sylvestre opened this issue May 6, 2021 · 2 comments · Fixed by #2210

Comments

@sylvestre
Copy link
Contributor

caused by #2138

Log:
https://travis-ci.org/github/uutils/coreutils/jobs/769608125

---- test_who::test_lookup stdout ----

current_directory_resolved: 

run: /home/travis/build/uutils/coreutils/target/debug/coreutils who --lookup
current_directory_resolved: 
run: who --lookup
thread 'test_who::test_lookup' panicked at 'assertion failed: `(left == right)`
Diff < left / right > :
<"travis   pts/0        2021-05-05 21:03 (\u{0}\u{0}\u{0}\u{0}\u{0}\u{0}\u{0}\u{0}10)\n"
>"travis   pts/0        2021-05-05 21:03 (10.16.5.10)\n"
', tests/common/util.rs:205:9
@sylvestre sylvestre mentioned this issue May 6, 2021
Merged
sylvestre added a commit that referenced this issue May 6, 2021
@sylvestre
Ignore test_lookup until issue #2181 is fixed
2b48557
@jhscheer
Copy link
Contributor

jhscheer commented May 6, 2021

Context:
The --lookup flag wasn't tested prior to #2138.
The test test_who::test_lookup doesn't always fail.

If this test makes trouble, ignoring it until this issue is fixed would be reasonable.

sylvestre added a commit that referenced this issue May 6, 2021
@sylvestre
Ignore test_lookup until issue #2181 is fixed
928fc59
@jhscheer
Copy link
Contributor

I am working on this.

jhscheer added a commit to jhscheer/coreutils that referenced this issue May 13, 2021
@jhscheer
who: fix --lookup
ef032e7 
This closes uutils#2181.

`who --lookup` is failing with a runtime panic (double free).
Since `crate::dns-lookup` already includes a safe wrapper for `getaddrinfo`
I used this crate instead of further debugging the existing code in
utmpx::canon_host().

* It was neccessary to remove the version constraint for libc in uucore.
@jhscheer jhscheer mentioned this issue May 13, 2021
Merged
jhscheer added a commit to jhscheer/coreutils that referenced this issue May 13, 2021
@jhscheer
who: fix --lookup
9c65d7a 
This closes uutils#2181.

`who --lookup` is failing with a runtime panic (double free).
Since `crate::dns-lookup` already includes a safe wrapper for `getaddrinfo`
I used this crate instead of further debugging the existing code in
utmpx::canon_host().

* It was neccessary to remove the version constraint for libc in uucore.
jhscheer added a commit to jhscheer/coreutils that referenced this issue May 13, 2021
@jhscheer
who: fix --lookup
1cabd9a 
This closes uutils#2181.

`who --lookup` is failing with a runtime panic (double free).
Since `crate::dns-lookup` already includes a safe wrapper for `getaddrinfo`
I used this crate instead of further debugging the existing code in
utmpx::canon_host().

* It was neccessary to remove the version constraint for libc in uucore.
jhscheer added a commit to jhscheer/coreutils that referenced this issue May 13, 2021
@jhscheer
who: fix --lookup
a4fc2b5 
This closes uutils#2181.

`who --lookup` is failing with a runtime panic (double free).
Since `crate::dns-lookup` already includes a safe wrapper for `getaddrinfo`
I used this crate instead of further debugging the existing code in
utmpx::canon_host().

* It was neccessary to remove the version constraint for libc in uucore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

who: fix --lookup jhscheer/coreutils
2 participants
@sylvestre @jhscheer