Skip to content

cksum: stops when one of given files doesn't exist #5809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
D9nni opened this issue Jan 8, 2024 · 4 comments · Fixed by #5820
Closed

cksum: stops when one of given files doesn't exist #5809

D9nni opened this issue Jan 8, 2024 · 4 comments · Fixed by #5820
Labels
good first issue For newcomers! U - cksum

Comments

@D9nni
Copy link
Contributor

D9nni commented Jan 8, 2024

GNU cksum shows an error message when a file does not exist and continues work with the next given arguments, while uutils cksum stops when error occurs.
GNU:

$ cksum README.md nothing Cargo.toml 
4037539306 8038 README.md
cksum: nothing: No such file or directory
3830277208 20970 Cargo.toml

uutils:

$ coreutils cksum README.md nothing Cargo.toml 
4037539306 8038 README.md
cksum: nothing: No such file or directory
@Hwatwasthat
Copy link

I could take this issue on, should be a quick fix to just match on the attempt to open the file and then carry on.

@cakebaker
Copy link
Contributor

@Hwatwasthat sure, go ahead :)

@biplab5464
Copy link
Contributor

i am sorry i am new to open source contribution am i doing right is their any other way

@Hwatwasthat
Copy link

No no that's fine, I was just offering to help out, nothing more :)

@cakebaker cakebaker linked a pull request Jan 10, 2024 that will close this issue
cksum: stops when one of given files doesn't exist #5809 #5820
Merged
@Ato2207 Ato2207 mentioned this issue Jan 12, 2024
Merged
cakebaker pushed a commit that referenced this issue Jan 15, 2024
@biplab5464
cksum: stops when one of given files doesn't exist #5809 (#5820)
076b905 
* cksum: stops when one of given files doesn't exist #5809

* removed printld  cksum: stops when one of given files doesn't exist #5809

* formatting the code cksum: stops when one of given files doesn't exist #5809

* formatting the code cksum: stops when one of given files doesn't exist #5809

* set exist status cksum: stops when one of given files doesn't exist #5809

* code quality formatting issue cksum: stops when one of given files doesn't exist #5809

* tertsdiepraam idea cksum: stops when one of given files doesn't exist #5809

* one new test case and deleted duplicate show cksum: stops when one of given files doesn't exist #5809

* formatting the test cases cksum: stops when one of given files doesn't exist #5809

* Revert "formatting the test cases cksum: stops when one of given files doesn't exist #5809"

This reverts commit 8c382f1.

* reverting the changes and committing again due to a mistake cksum: stops when one of given files doesn't exist #5809

---------

Co-authored-by: biplab5464 <biplab5464@outlook.com>
@cakebaker cakebaker mentioned this issue Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For newcomers! U - cksum
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cksum: stops when one of given files doesn't exist #5809
4 participants
@cakebaker @Hwatwasthat @biplab5464 @D9nni