Fix+modernize #1442
Merged
Fix+modernize #1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- convert to newer `..=` syntax, fixing compiler warnings + requires MinSRV >= v1.26.0 .# [why] The inclusive range operator (`..=`) was stabilized in rust v1.26.0. Warnings requesting conversion from the old `...` operator to `..=` were introduced in rust v1.37.0. * ref: <https://github.com/rust-lang/rust/blob/master/RELEASES.md>
- convert to newer `?` syntax, fixing compiler warnings + requires MinSRV >= v1.13.0 .# [why] The `?` operator was stabilized in rust v1.13.0. Warnings requesting conversion from the old `try!` macro to the `?` operator were introduced in rust v1.39.0. * ref: <https://github.com/rust-lang/rust/blob/master/RELEASES.md>
…t,end}...`
- `trim_{start,end}{,_matches}` stabilized in rust v1.30.0
- `trim_{start,end}{,_matches}` deprecated (with compiler warnings) in rust v1.33.0
+ requires MinSRV >= v1.30.0
* ref: https://github.com/rust-lang/rust/blob/master/RELEASES.md
- rust usually uses `assert_eq!(ACTUAL, EXPECTED)` - ref: https://users.rust-lang.org/t/assert-eq-expected-and-actual/20304/3 @@ https://archive.is/xPp9R
+ ToDO added ~ when possible, test under WSL2 and differentiate/liberalize if possible
…ions
- allow actual outputs to differ from expected (ie, `stat`) if `stat` is reporting "unknown" creation time
.# [why]
For many *nix flavors, `stat` is unable to detect birth/creation date
for directories/files. The information is available via the `statx()`
system call (for linux kernels >= v4.11), and rust supplies that
information via fs::MetadataExt for v1.40+. So, for rust v1.40+, there
will likely be a mismatch between the output of the system `stat` and
this ('uutils') `stat`.
* ref: <https://askubuntu.com/questions/470134/how-do-i-find-the-creation-time-of-a-file> @@ <https://archive.is/IsEAJ>
…at due to race conditions
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of the windows_legacy fix/addition PR.
cargo makesupport for platform dependent build and testing (usingcargo makeandcargo make test, respectively)try!, and 3)trim_{left,right}statI'm happy to make changes.
This is really a preliminary PR to fix all broken/deprecation issues and serving as a base for a separate (massive) "clippy-cleanup" PR.