Skip to content

gnu/test: add the iso en_us locale to help with some tests #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2022
Merged

gnu/test: add the iso en_us locale to help with some tests #2753

merged 1 commit into from
Feb 13, 2022

Conversation

sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Nov 21, 2021 •
edited
Loading

Closes #2754

We are regressing deliberately because they are actual issues.

@sylvestre sylvestre mentioned this pull request Nov 21, 2021
Merged
@sylvestre sylvestre mentioned this pull request Nov 21, 2021
Closed
@sylvestre
Copy link
Contributor Author

Failed because
Warning: Changes from master: PASS -2 / FAIL +3 / ERROR +0 / SKIP -1
Reasons:

Error: GNU test failed: tests/misc/expr-multibyte. tests/misc/expr-multibyte is passing on 'master'. Maybe you have to rebase?
Error: GNU test failed: tests/misc/sort-debug-keys. tests/misc/sort-debug-keys is passing on 'master'. Maybe you have to rebase?
Error: GNU test failed: tests/misc/sort-month. tests/misc/sort-month is passing on 'master'. Maybe you have to rebase?

@sylvestre
Copy link
Contributor Author

tests/misc/sort-month failing is #3123

@sylvestre
Copy link
Contributor Author

tests/misc/sort-debug-keys fails on https://github.com/coreutils/coreutils/blob/master/tests/misc/sort-debug-keys.sh#L321-L334

@sylvestre sylvestre removed request for rivy and miDeb February 13, 2022 09:23
@sylvestre
Copy link
Contributor Author

@tertsdiepraam I think we should merge it if you are ok with it
@jfinkels what do you think ? :)

@sylvestre
Copy link
Contributor Author

The clippy warning is already fixed: #3124

@tertsdiepraam
Copy link
Member

Yeah looks good to me!

@sylvestre
Copy link
Contributor Author

@tertsdiepraam could you please land then ? :)

@tertsdiepraam tertsdiepraam merged commit 1167d81 into uutils:main Feb 13, 2022
@tertsdiepraam
Copy link
Member

I was waiting for jfinkels, but sure :)

@sylvestre sylvestre deleted the gnu-locale branch February 13, 2022 12:02
@sylvestre
Copy link
Contributor Author

oh, ok, merci :)

@jfinkels
Copy link
Collaborator

Hi! I think this will be great for revealing more errors. I don't know much about using locales (I'm on en_US.UTF-8 and I don't speak other languages, unfortunately) but I'm happy to learn. Does this affect the Quotable trait?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GNU test CI needs some more locale work
3 participants
@sylvestre @tertsdiepraam @jfinkels