-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Create coverage report for GNU tests #3045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
excellent stuff, thanks :) What about "Run GNU tests" and "Run GNU tests with coverage" ? |
I very much appreciate this effort, but I'm concerned about adding this workflow to the usual CI runs. And, in looking at the coverage diff, I don't see much of a coverage change either... only a few lines here with lots of them being changes to coverage of help message lines. Maybe only enable it for merges to 'main'? |
I think this link shows the correct coverage change of this pull request. |
Hmm, if I understand it correctly, it is adding on top of the current one ? |
@xxyzz , That's definitely a much better gain (on the order of ~500 net line coverage gain)! Thanks for showing me that comparison mode. So, any ideas about how can we add this in a way that doesn't severely slow the CI for regular PRs? |
I suspect the test runs slower because optimizations are disabled. I already let the new job only runs on the main branch in the last commit as you suggested. |
I approved earlier a patch from @rivy before |
@xxyzz , I'm happy to fix the merge conflicts (especially since I caused them I want to merge some maintenance work (PR #3090) on the configuration and 'util' scripts first, then I'll rebase your additions on top and push them back here. Ok? |
Alright, thanks for solving the conflicts. |
593f75a
to
bcb26d9
Compare
let's see :) |
I should run |
@xxyzz quick question, how can I use codecov to compare the gnu vs rust testsuite ? :) |
I noticed that you have
but I don't see them on https://app.codecov.io/gh/uutils/coreutils |
The GNU tests report only created when commits pushed to the main branch, so only the merge commits have it. Codecov says "Flags have been temporarily removed" in the compare page overview tab, but the app subdomain still has it. And as the notice said, flags can be used on files. |
thanks again :) One more question @xxyzz
|
f11ac4b is a merge commit, so it has one more GNU coverage report then a PR. Now the GNU coverage job takes around one hour to finish, maybe it's time to enable it in pull requests so it can be compared? |
Sounds good :) |
Closes #2946.