Remove unused dependencies by individual crates #3264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent! Have you made the tool public? |
|
Works great, many thanks :) Maybe it is going to have a positive impact on: |
It's open source and in my repos 👀 but not yet officially public! I've wanted to write a small blog post announcement, explaining how it works and its limitations first. |
|
Very cool! Looking forward to it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a small tool of my creation to remove unused dependencies; I've seen that
cargo-udepswas used, but I've found that it has a few imperfections, as it cannot detect unused dependencies of individual crates within a common workspace. This shouldn't bring large build time improvements, but it change the graph of crate dependencies and thus cause some little wins due to cargo pipelining effects. I haven't observed any improvement outside the range of noise here, unfortunately.The tool I'm using can be imprecise, so I'm curious to see if CI will be happy with the changes...