Skip to content

Conversation

tertsdiepraam
Copy link
Member

@tertsdiepraam tertsdiepraam commented May 1, 2022

The Windows tests are currently failing on all new PRs. This is due to an incorrect regex in the tests for dir and vdir. The regex was:

[rwx][^some-file1]

which was probably supposed to mean: "any of rxw but not some-file1". This is wrong because it matches any r, w or x that is not followed by the characters in some-file1. On my machine, my username is terts which then also matches. Secondly, it does not match - which is all we output on Windows.

So what happened is that the Windows tests were only "correct", because the string April matched the regex until yesterday, making the Windows tests succeed until April was over and May began :).

I've change the regex to check both a string of rwx- characters and the filename:

[rwx-]{10}.*some-file1$

@sylvestre
Copy link
Contributor

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants