dir
, vdir
: fix incorrect regex in tests
#3460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows tests are currently failing on all new PRs. This is due to an incorrect regex in the tests for
dir
andvdir
. The regex was:which was probably supposed to mean: "any of
rxw
but notsome-file1
". This is wrong because it matches anyr
,w
orx
that is not followed by the characters insome-file1
. On my machine, my username isterts
which then also matches. Secondly, it does not match-
which is all we output on Windows.So what happened is that the Windows tests were only "correct", because the string
April
matched the regex until yesterday, making the Windows tests succeed untilApril
was over andMay
began :).I've change the regex to check both a string of
rwx-
characters and the filename: