Skip to content

test/cp: advanced xattr tests with a simple in memory fs using fuse #4100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 69 commits into from
Closed

test/cp: advanced xattr tests with a simple in memory fs using fuse #4100

wants to merge 69 commits into from

Conversation

sssemil
Copy link
Contributor

@sssemil sssemil commented Nov 1, 2022

Continuation of what was started here #4095 and then moved here #4099.

Basically, this fuse fs implementation aims at simulating various xattr test cases for cp.

@sssemil sssemil mentioned this pull request Nov 1, 2022
Closed
@sssemil sssemil changed the title Advanced xattr tests with a simple in memory fs using fuse test_cp: advanced xattr tests with a simple in memory fs using fuse Nov 1, 2022
@sssemil sssemil mentioned this pull request Nov 1, 2022
Merged
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

GNU testsuite comparison:

GNU test failed: tests/misc/timeout. tests/misc/timeout is passing on 'main'. Maybe you have to rebase?

@sssemil sssemil changed the title test_cp: advanced xattr tests with a simple in memory fs using fuse test/cp: advanced xattr tests with a simple in memory fs using fuse Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

@sssemil sssemil force-pushed the testfs branch 2 times, most recently from 2c0eaaa to af83d18 Compare December 7, 2022 14:11
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!
GNU test failed: tests/misc/tee. tests/misc/tee is passing on 'main'. Maybe you have to rebase?

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!
GNU test failed: tests/misc/tee. tests/misc/tee is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!
GNU test failed: tests/misc/tee. tests/misc/tee is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

2 similar comments
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@sssemil sssemil force-pushed the testfs branch 2 times, most recently from e44b79a to 5901895 Compare January 18, 2023 13:00
sssemil added 10 commits January 18, 2023 14:05
@sssemil
cp: require preserve only certain attributes
3daf05c 
# Conflicts:
#	src/uu/cp/src/copydir.rs
#	src/uu/cp/src/cp.rs
@sssemil
tests/cp: preserve all and preserve xattr tests with todos
682b153
@sssemil
tests/cp: rename preserve tests
e660242
@sssemil
tests/cp: add android fail test for preserve=xattr
382f549 
On Android, this cp with explicit preserve of xattr must fail, because of the limitations of the filesystem setup used on Android.
@sssemil
cp: verify some metadata in cp preserve tests
f4aa2cb 
# Conflicts:
#	tests/by-util/test_cp.rs
@sssemil
cp: run test_cp_preserve_all in all OS's but only check metadata on l…
05e0fd2 
…inux
@sssemil
test/cp: don't expect the mode to change in explicit cp preserve
feb4d8c
@sssemil
cp: attributes struct instead of enum for unified required tracking
24ff9d6
@sssemil
cp: refactor preserver and handle_preserve
d9c7313 
# Conflicts:
#	src/uu/cp/src/cp.rs
@sssemil
cp: update preserve attr to max
8ea52fc
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!
GNU test failed: tests/misc/timeout. tests/misc/timeout is passing on 'main'. Maybe you have to rebase?

@sylvestre
Copy link
Contributor

are you still interested by this PR ?

sylvestre
sylvestre requested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still draft

@sssemil
Copy link
Contributor Author

sssemil commented Mar 27, 2023

Yep, just a bit busy lately

@sylvestre
Copy link
Contributor

@sssemil ping ?

@uutils uutils deleted a comment from github-actions bot Jun 20, 2023
@uutils uutils deleted a comment from github-actions bot Jun 20, 2023
@uutils uutils deleted a comment from github-actions bot Jun 20, 2023
@uutils uutils deleted a comment from github-actions bot Jun 20, 2023
@uutils uutils deleted a comment from github-actions bot Jun 20, 2023
@uutils uutils deleted a comment from github-actions bot Jun 20, 2023
@uutils uutils deleted a comment from github-actions bot Jun 20, 2023
@sssemil
Copy link
Contributor Author

sssemil commented Jun 21, 2023

@sssemil ping ?

hey @sylvestre feel free to take over if you have time, I'm still unavailable 😔

@sylvestre
Copy link
Contributor

inactive, so, closing

@sylvestre sylvestre closed this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sssemil @tertsdiepraam @sylvestre