Skip to content

cp: make --preserve use the defaults when empty #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

sssemil
Copy link
Contributor

@sssemil sssemil commented Nov 9, 2022

cp --preserve with no arguments doesn't use the default attributes. This PR fixes it.

Tests for various preserve cases will be added here: #4099.

Closes #4122.

@sylvestre sylvestre force-pushed the preserve_noargs_4122 branch from d8fddd6 to b749bc2 Compare November 10, 2022 11:45
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/timeout. tests/misc/timeout is passing on 'main'. Maybe you have to rebase?

@tertsdiepraam
Copy link
Member

Nice! Could you put at least one test here anyway? That also makes it so that the other PR does not rely on this one anymore.

@sylvestre sylvestre force-pushed the preserve_noargs_4122 branch from b749bc2 to 09bd4b6 Compare November 15, 2022 13:22
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/misc/timeout is no longer failing!

@sssemil sssemil force-pushed the preserve_noargs_4122 branch from 09bd4b6 to a6c48b0 Compare November 16, 2022 00:43
@sssemil
Copy link
Contributor Author

sssemil commented Nov 16, 2022

@tertsdiepraam done :)

Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@tertsdiepraam tertsdiepraam merged commit 7330eff into uutils:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cp: --preserve with no arguments doesn't use the default attributes
2 participants