Skip to content

nl: implement TryFrom<&str> for NumberingStyle #5156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2023
Merged

nl: implement TryFrom<&str> for NumberingStyle #5156

merged 1 commit into from
Aug 18, 2023

Conversation

cakebaker
Copy link
Contributor

This PR implements TryFrom<String> for NumberingStyle to replace the parse_style function.

@cakebaker cakebaker force-pushed the nl_implement_try_from_for_numbering_style branch from 95ea18a to 6bdeada Compare August 12, 2023 14:57
tertsdiepraam
tertsdiepraam approved these changes Aug 12, 2023
View reviewed changes
@tertsdiepraam
Copy link
Member

I like the new version a lot better than the old one!

@cakebaker cakebaker force-pushed the nl_implement_try_from_for_numbering_style branch from 6bdeada to d5ab7bb Compare August 13, 2023 12:09
@cakebaker cakebaker changed the title nl: implement TryFrom<String> for NumberingStyle nl: implement TryFrom<&str> for NumberingStyle Aug 13, 2023
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail-2/inotify-dir-recreate

@tertsdiepraam tertsdiepraam merged commit f197895 into uutils:main Aug 18, 2023
@cakebaker cakebaker deleted the nl_implement_try_from_for_numbering_style branch August 19, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @tertsdiepraam