Skip to content

expr: interpret numbers != 0 as true for | and & #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2023
Merged

expr: interpret numbers != 0 as true for | and & #5324

merged 1 commit into from
Sep 26, 2023

Conversation

cakebaker
Copy link
Contributor

So far when using | or & numbers were only interpreted as true if they were 1. This PR changes this behavior, now any number != 0 is interpreted as true.

Fixes #5315 and #5316

@cakebaker cakebaker linked an issue Sep 26, 2023 that may be closed by this pull request
"/usr/bin/expr 90 \| 67 = 10" has a different output & error code than GNU #5316
Closed
@sylvestre sylvestre merged commit f31c017 into uutils:main Sep 26, 2023
@sylvestre
Copy link
Contributor

excellent, thanks.
the fuzzer is running a bit longer :)

@cakebaker cakebaker deleted the expr_fix_and_and_or branch September 27, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"/usr/bin/expr 90 \| 67 = 10" has a different output & error code than GNU expr 50 & 40 is behaving differently than GNU
2 participants
@cakebaker @sylvestre