Skip to content

hashsum: Remove usage of crash! macro #5581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2023
Merged

hashsum: Remove usage of crash! macro #5581

merged 1 commit into from
Nov 26, 2023

Conversation

GDYendell
Copy link
Contributor

@GDYendell GDYendell commented Nov 25, 2023 •
edited
Loading

Remove usage of the crash! macro for error handling and instead return a UResult from detect_algo.

Part of #5487

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail/inotify-dir-recreate. tests/tail/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@GDYendell GDYendell force-pushed the hashsum-remove-crash branch from 9fc5c94 to b6553ed Compare November 26, 2023 10:38
tertsdiepraam
tertsdiepraam approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Thanks!

@tertsdiepraam tertsdiepraam merged commit cd4f455 into uutils:main Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GDYendell @tertsdiepraam