Skip to content

install: support when a hyphen is passed #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 23, 2023
Merged

install: support when a hyphen is passed #5697

merged 3 commits into from
Dec 23, 2023

Conversation

sylvestre
Copy link
Contributor

Should fix: tests/install/strip-program.sh

@sylvestre
install: support when a hyphen is passed
76a5768 
Should fix: tests/install/strip-program.sh
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/install/strip-program is no longer failing!
Skip an intermittent issue tests/tail/inotify-dir-recreate

cakebaker
cakebaker reviewed Dec 23, 2023
View reviewed changes
cakebaker
cakebaker reviewed Dec 23, 2023
View reviewed changes
sylvestre and others added 2 commits December 23, 2023 14:59
@sylvestre @cakebaker
Improve the comment
9f7472c 
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
@sylvestre @cakebaker
Improve check
08b0e67 
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
cakebaker
cakebaker approved these changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you notice that there is no output when running cargo run --features="unix" install -s --strip-program ./no-hyphen -- source -dest whereas GNU outputs ./-dest? Should I open a ticket for it?

@sylvestre
Copy link
Contributor Author

yeah, probably :)

@sylvestre sylvestre merged commit 2832694 into uutils:main Dec 23, 2023
@sylvestre sylvestre deleted the hiphen branch December 23, 2023 14:29
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/install/strip-program is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate

@cakebaker cakebaker mentioned this pull request Dec 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker approved these changes

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker