fix uucore/fsext/MountInfo::new mount_dir not unescaped #5754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
7078771 to
06e94f7
Compare
|
@Yykz is it ready to be reviewed? thanks sorry for the latency |
|
GNU testsuite comparison: |
sylvestre
reviewed
Sep 16, 2024
Comment on lines
+163
to
+165
| .replace(r#"\040"#, " ") | ||
| .replace(r#"\011"#, " ") | ||
| .replace(r#"\134"#, r#"\"#); |
There was a problem hiding this comment.
Suggested change
| .replace(r#"\040"#, " ") | |
| .replace(r#"\011"#, " ") | |
| .replace(r#"\134"#, r#"\"#); | |
| // Replace ASCII space with a regular space character | |
| .replace(r#"\040"#, " ") | |
| // Replace \011 ASCII horizontal tab with a tab character | |
| .replace(r#"\011"#, " ") | |
| // Replace ASCII backslash with an actual backslash character | |
| .replace(r#"\134"#, r#"\"#); |
There was a problem hiding this comment.
and it should be moved into a function
There was a problem hiding this comment.
@Yykz did you see this comment? thanks :)
06e94f7 to
fbc5733
Compare
|
done here: #7151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the continuation of #5679, I accidentally deleted my branch and I can't re-open the PR
sorry for the inconvenience