printf : no infinite loop #5830

sudhackar · 2024-01-12T10:42:26Z

$ printf a b
a

This PR adds a test for this behaviour. at this moment - the iter from parse_spec_and_escape function won't consume args if no format string is present and goes to an infinite loop.

coreutils/src/uu/printf/src/printf.rs

Lines 49 to 54 in edb77b8

    
           while args.peek().is_some() { 
        
               for item in parse_spec_and_escape(format_string.as_ref()) { 
        
                   match item?.write(stdout(), &mut args)? { 
        
                       ControlFlow::Continue(()) => {} 
        
                       ControlFlow::Break(()) => return Ok(()), 
        
                   };

sudhackar · 2024-01-12T11:08:56Z

failures seem unrelated - "https://busybox.net/downloads/busybox-1.35.0.tar.bz2" is timing out and some issues with termux apt get.

github-actions · 2024-01-12T11:32:23Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

tertsdiepraam

Cool! Seems correct to me and with a nice test. I just have a small suggestion.

src/uu/printf/src/printf.rs

cakebaker · 2024-01-12T13:50:31Z

Thanks for your PR :)

sudhackar added 2 commits January 12, 2024 16:08

printf : no infinite loop

2aa8a35

printf: fix clippy warnings

4e5a65e

tertsdiepraam reviewed Jan 12, 2024

View reviewed changes

src/uu/printf/src/printf.rs Outdated Show resolved Hide resolved

printf: simplify loop

cd4568f

cakebaker merged commit 7e3f4d8 into uutils:main Jan 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

printf : no infinite loop #5830

printf : no infinite loop #5830

sudhackar commented Jan 12, 2024

sudhackar commented Jan 12, 2024 •

edited

Loading

github-actions bot commented Jan 12, 2024

tertsdiepraam left a comment

cakebaker commented Jan 12, 2024

	while args.peek().is_some() {
	for item in parse_spec_and_escape(format_string.as_ref()) {
	match item?.write(stdout(), &mut args)? {
	ControlFlow::Continue(()) => {}
	ControlFlow::Break(()) => return Ok(()),
	};

printf : no infinite loop #5830

printf : no infinite loop #5830

Conversation

sudhackar commented Jan 12, 2024

sudhackar commented Jan 12, 2024 • edited Loading

github-actions bot commented Jan 12, 2024

tertsdiepraam left a comment

Choose a reason for hiding this comment

cakebaker commented Jan 12, 2024

sudhackar commented Jan 12, 2024 •

edited

Loading