Skip to content

ci:android stabilize and improve android github actions #5939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cre4ture
Copy link
Contributor

@cre4ture cre4ture commented Feb 3, 2024

I did the following changes which make the build significantly more robust:

  • increase RAM and disk size (from original 1.5GB to: 4GB ram -> x86, 8GB ram -> x86_46, disk: 12GB)
  • use own pre-defined mirror list for termux package manager to be able to disable brocken mirrors
  • install (install sshd and a public key from runner) and use ssh connection to termux for less error prone scripting on android with more reliable progress and error reporting
  • periodically print disk- and ram-usage during test execution to see if we run into ressource issues
  • limit available memory for test execution to 3GB (ulimit) to avoid that the OS kills the sshd server process
  • when using "adb shell input text" split the transmition into chunks to support longer commands.
  • take and upload screenshots during startup and installation to see reason for failures during that process
  • set number of cores to 4 for better performance
  • switched from mac-os based runner to linux as this speeds up emulator start, build and test execution
  • add timestamp to command output from ssh to detect and compare delays in execution
  • updated reactivecircus/android-emulator-runner to latest verision: @v2.30.1
  • close potential startup dialog "System UI isn't responding" with "wait"

All the testing took quite some time. I did't spend more time for splitting this change into smaller peaces. Hope this is fine.

Both android builds are currently red due to failing tests. For two of them I have fixes, but I will create new PRs for those: #5821 and #5940

@cre4ture
Copy link
Contributor Author

cre4ture commented Feb 3, 2024

@cakebaker sorry, I didn't know that you are also working on it

@tertsdiepraam
Copy link
Member

Cool! I'm not an expert on this, but it looks good and if it improves the Android CI, I'm all for it.

@cre4ture cre4ture changed the title stabilize and improve android github actions ci:android stabilize and improve android github actions Feb 4, 2024
@cre4ture
Copy link
Contributor Author

cre4ture commented Feb 4, 2024

Cool! I'm not an expert on this, but it looks good and if it improves the Android CI, I'm all for it.

Thanks.
Do you know who we need to ask for giving this pull request a bit priority?
I think it would be important to have fully green CI builds soon.

@sylvestre sylvestre requested a review from cakebaker February 4, 2024 11:42
@sylvestre
Copy link
Contributor

LGTM. I just would like @cakebaker to review it too as he worked on this recently too.

@tertsdiepraam
Copy link
Member

Do you know who we need to ask for giving this pull request a bit priority?

Sylvestre, cakebaker and me and we're all involved already so this has priority! :)

@cakebaker cakebaker merged commit 40694c5 into uutils:main Feb 4, 2024
@cakebaker
Copy link
Contributor

Great job, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants