Skip to content

tr: fix "space" class, test "blank" class for order #6141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2024
Merged

tr: fix "space" class, test "blank" class for order #6141

merged 2 commits into from
Mar 29, 2024

Conversation

BenWiederhake
Copy link
Collaborator

This addresses a stand-alone issue originally documented in #6133, but can be solved independently: Our space class was wrong. As a drive-by, I also wrote a test to make sure our space class never gets messed up.

@BenWiederhake BenWiederhake mentioned this pull request Mar 29, 2024
Closed
@BenWiederhake
Copy link
Collaborator Author

CI is flaky:

2024-03-29T00:06:14.1473580Z [command]/usr/bin/tar --posix -cf cache.tzst --exclude cache.tzst -P -C /home/runner/work/coreutils/coreutils --files-from manifest.txt --use-compress-program zstdmt
2024-03-29T00:06:14.2280795Z Failed to save: Unable to reserve cache with key corpus-cache-fuzz_echo, another job may be creating this cache. More details: {"$id":"1","innerException":null,"message":"Request was blocked due to exceeding usage of resource 'Count' in namespace '.","typeName":"Microsoft.TeamFoundation.Framework.Server.RequestBlockedException, Microsoft.TeamFoundation.Framework.Server","typeKey":"RequestBlockedException","errorCode":0,"eventId":3000}`

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@cakebaker cakebaker merged commit 20a5e96 into uutils:main Mar 29, 2024
@cakebaker
Copy link
Contributor

Thanks :)

@BenWiederhake BenWiederhake deleted the dev-tr-space-class branch March 29, 2024 15:49
@BrewTestBot BrewTestBot mentioned this pull request Apr 27, 2024
Merged
@moonfruit moonfruit mentioned this pull request Apr 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenWiederhake @cakebaker