Skip to content

kill: accept all cases for signal names #6229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2024
Merged

kill: accept all cases for signal names #6229

merged 2 commits into from
Apr 15, 2024

Conversation

m-haisham
Copy link
Contributor

This PR updates the signal name comparison to work with all cases. The changes are effective on --list and --signal commands.

$ cargo run --features kill kill -l sIgUsR2
12
[$? = 1]
$ kill -l sIgUsR2 # bash built-in
12
$ /usr/bin/kill -l sIgUsR2 # Debian procps-ng 4.0.4
12

Fixes #6217

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/timeout/timeout is no longer failing!

BenWiederhake
BenWiederhake approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does exactly what it says on the tin, and thorough tests. Thank you! :D

@BenWiederhake BenWiederhake merged commit b617876 into uutils:main Apr 15, 2024
@BrewTestBot BrewTestBot mentioned this pull request Apr 27, 2024
Merged
@moonfruit moonfruit mentioned this pull request Apr 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWiederhake BenWiederhake BenWiederhake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kill: signal names only understood in uppercase, should accept all casings
2 participants
@m-haisham @BenWiederhake