cp: parent-perm-race gnu fix #6403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
b103d1b to
3700547
Compare
|
GNU testsuite comparison: |
0e28cd3 to
eec25a0
Compare
|
GNU testsuite comparison: |
58fac2b to
d720a91
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
d720a91 to
382cf00
Compare
382cf00 to
cba3253
Compare
|
GNU testsuite comparison: |
|
terrific! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this pr tries to fix parent-perm-race gnu test case. this test tries to check the temporary permissions of directories created by cp which might be too permissive under some conditions.
This is how gnu's cp behaves, when
--preserve=modeor--preserve=ownershipis given whenever it creates a directory it disables some permissions forgroupandothers. I'm not entirely sure why gnu's cp is doing this, but my assumption is that when the user tries to preserve mode or ownership they're expecting some security guarantees in the destination directory, but having permissions that are too permissive even for a short period of time might compromise that security guarantee.#4211 is a pr that fixes a similar issue