Skip to content

tr: disallow classes besides [:upper:]/[:lower:] in set2 when translating #6424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2024
Merged

tr: disallow classes besides [:upper:]/[:lower:] in set2 when translating #6424

merged 1 commit into from
May 23, 2024

Conversation

cvonelm
Copy link
Contributor

@cvonelm cvonelm commented May 23, 2024

To simplify the checks for [:upper:] and [:lower:], I have separated the character classes into a sub-enum.

Additionally, I have implemented the divergent tr behaviour from the issue into a testcase.

Fixes issue #6342

@cakebaker cakebaker linked an issue May 23, 2024 that may be closed by this pull request
tr: Should not allow special classes in set2 #6342
Closed
@BenWiederhake
Copy link
Collaborator

BenWiederhake commented May 23, 2024 •
edited
Loading

What a straight-forward implementation! Awesome, thanks :)

EDIT: Nearly forgot to mention, remaining failures are just #6275 and #6419.

@BenWiederhake BenWiederhake merged commit 0d1bde2 into uutils:main May 23, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 23, 2024
Merged
@moonfruit moonfruit mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tr: Should not allow special classes in set2
2 participants
@cvonelm @BenWiederhake