Skip to content

gnu cp-parents test case #6446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2024
Merged

gnu cp-parents test case #6446

merged 5 commits into from
Jun 17, 2024

Conversation

matrixhead
Copy link
Contributor

@matrixhead matrixhead commented Jun 3, 2024 •
edited
Loading

This PR aims to fix the GNU cp-parents test case. The following behaviors have been changed in this PR:

  • if dereference is enabled and --preserve attributes are specified, instead of copying the attributes of the symlink itself, cp will try to copy the attributes of the actual file the symlink points to.
  • --parents will not fail if an absolute path is given (I couldn't make this work on Windows).
  • For GNU compatibility, cp will not return an error if setting ownership fails.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/cp/cp-parents is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/cp/cp-parents is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@matrixhead matrixhead force-pushed the cp-parents branch 2 times, most recently from 8732b07 to 651fc7c Compare June 3, 2024 12:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/cp/cp-parents is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/cp/cp-parents is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/cp/cp-parents is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cp/cp-parents is no longer failing!

@sylvestre
Copy link
Contributor

it is still marked as draft, please remove it when ready :)

@matrixhead matrixhead marked this pull request as ready for review June 4, 2024 13:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/cp/cp-parents is no longer failing!

@sylvestre sylvestre merged commit e46ad30 into uutils:main Jun 17, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 23, 2024
Merged
@moonfruit moonfruit mentioned this pull request Jun 24, 2024
Merged
@drinkcat drinkcat mentioned this pull request Aug 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matrixhead @sylvestre