cksum/hashsum: add support of --check with base64 + other improvs #6452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cakebaker merged 13 commits into uutils:main from sylvestre:base64

Jun 27, 2024

Contributor

sylvestre commented Jun 4, 2024

No description provided.

github-actions bot commented Jun 4, 2024

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

github-actions bot commented Jun 4, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

sylvestre requested a review from cakebaker

June 4, 2024 21:54

github-actions bot commented Jun 4, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

cakebaker reviewed

View reviewed changes

tests/by-util/test_cksum.rs Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

tests/by-util/test_cksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

tests/by-util/test_cksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

github-actions bot commented Jun 5, 2024

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

sylvestre requested a review from cakebaker

June 5, 2024 10:15

cakebaker reviewed

View reviewed changes

tests/by-util/test_cksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

github-actions bot commented Jun 18, 2024

GNU testsuite comparison:

GNU test failed: tests/rm/rm2. tests/rm/rm2 is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!
Skipping an intermittent issue tests/rm/rm1 (passes in this run but fails in the 'main' branch)

sylvestre requested a review from cakebaker

June 18, 2024 20:58

github-actions bot commented Jun 18, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

cakebaker reviewed

View reviewed changes

src/uucore/Cargo.toml Outdated Show resolved Hide resolved

github-actions bot commented Jun 19, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

sylvestre requested a review from cakebaker

June 22, 2024 07:57

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

sylvestre added 12 commits

June 25, 2024 19:00


          cksum/hashsum: add support of --check with base64

66ccb1a


          cksum/hashsum: move to quick-error

edae51d


          cksum/hashsum: move to thiserror

cc8bda5


          cksum/hashsum: move the file mgmt into a function

e6aad95


          cksum/hashsum: use a struct to keep the results

a6bae64


          cksum/hashsum: Move the opening into a dedicated function

520907e


          cksum/hashsum: Move the algo mgmt into a dedicated function

e7898ab


          cksum/hashsum: Move the algo mgmt into a dedicated function

c2292a8


          cksum/hashsum: Simplify the determine_regex function

6922e7f


          cksum base64: update the GNU test to manage our output

ab2cc2f


          Address review comments

2e704b8


          cksum: Allow the indiv build

adcc548

sylvestre requested a review from cakebaker

June 25, 2024 19:24


          Adjust identify_algo_name_and_length to return Option<(String, Option…

212ddf7

…<usize>)> instead of (String, Option<usize>)

github-actions bot commented Jun 26, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

cakebaker merged commit 9b3b9e8 into uutils:main

Contributor

cakebaker commented Jun 27, 2024

Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

Great :)

BrewTestBot mentioned this pull request

uutils-coreutils 0.0.28 Homebrew/homebrew-core#197947

Merged

moonfruit mentioned this pull request

uutils-selected 0.0.28 moonfruit/homebrew-tap#178

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet