Refuse to translate if set1 is longer than set2 and set2 ends in a character class #6470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aracter class tr [:lower:]a [:upper:] fails in GNU tr, so print an error for tr too.
|
GNU testsuite comparison: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should fall in line with GNU behaviour here.
If you really think you need to do this:
you can already do this:
which does the same thing and is more explicit about which character is repeated to fill set2.
(Although generally, I think that if you are at that point you are already using the wrong tool).
However, I do not have strong opinions on this and would happily implement this the other way if someone is clearly in favour of that.