hashsum/b2sum: when the checksum file is untagged, detect the size #6499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
commented
Jun 27, 2024
| binary, | ||
| tag: matches.get_flag("tag"), | ||
| nonames, | ||
| //status, |
There was a problem hiding this comment.
I will fix/remove these comments after it lands
|
GNU testsuite comparison: |
|
The test fails on Windows as there is no |
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
cakebaker
reviewed
Jun 27, 2024
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
cakebaker
reviewed
Jun 28, 2024
cakebaker
reviewed
Jun 28, 2024
Should fix tests/cksum/b2sum.sh
cakebaker
approved these changes
Jun 28, 2024
Good work :) |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix tests/cksum/b2sum.sh