tr: correctly detected matched [:upper:] #6513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tr detects if a class in set2 is matched by a class at the correct position in set1 after it has expanded everything before the class in both sets: So tr 'abcd[:upper:]' 'a-d[:lower:]' should not fail
|
GNU testsuite comparison: |
Sweet! |
sylvestre
reviewed
Jun 30, 2024
| Self::Char(c) => Box::new(std::iter::once(*c)), | ||
| Self::CharRange(l, r) => Box::new(*l..=*r), | ||
| Self::CharStar(c) => Box::new(std::iter::repeat(*c)), | ||
| Self::CharRepeat(c, n) => Box::new(std::iter::repeat(*c).take(*n)), | ||
| Self::Class(class) => match class { |
There was a problem hiding this comment.
I think you could do
Box::new(match class
to avoid the Box::new duplication, no?
There was a problem hiding this comment.
The arms of the match all return slightly different types of iterators over Sequence, so unless there is Rust trick I am missing, we have to Box them right there to stop Rust from complaining about the match arms having icompatible types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tr detects if a class in set2 is matched by a class at the correct position in set1 after it has expanded everything before the class:
So
tr 'abcd[:upper:]' 'a-d[:lower:]'
should not fail
Fixes #6445