Skip to content

mv: inter partition copying test code cleanup #6583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2024
Merged

mv: inter partition copying test code cleanup #6583

merged 3 commits into from
Jul 19, 2024

Conversation

matrixhead
Copy link
Contributor

code cleanup for #6578

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

BenWiederhake
BenWiederhake requested changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this up again! In the meantime, I found/remembered the shortcut functions, maybe it's a better idea to use those? The error reporting from inside the test doesn't need to be too detailed anyway.

@matrixhead matrixhead requested a review from BenWiederhake July 19, 2024 03:21
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

BenWiederhake
BenWiederhake requested changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a wrong comma. (Weird, CI should have caught that.)

@matrixhead @BenWiederhake
Update tests/by-util/test_mv.rs
f537fc3 
Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
BenWiederhake
BenWiederhake approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only CI failure is unrelated (#6534)

@BenWiederhake BenWiederhake merged commit 5baf382 into uutils:main Jul 19, 2024
67 of 68 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 16, 2024
Merged
@moonfruit moonfruit mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWiederhake BenWiederhake BenWiederhake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matrixhead @BenWiederhake