Skip to content

cksum/hashsum: Support for commented lines in checksum files #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2024
Merged

cksum/hashsum: Support for commented lines in checksum files #6782

merged 3 commits into from
Oct 18, 2024

Conversation

RenjiSann
Copy link
Collaborator

As #6603 implicitly implemented commented line support, I moved it into its own PR, with proper testing.

TL;DR:
This change make the checksum verification system ignore lines starting with #, treating them as empty lines.

Example:

$ echo 'foo-content' > foo
$ cksum --algo=sha1 foo | tee CHECKSUM
SHA1 (foo) = 058ab38dd3603703b3a7063cf95dc51a4286b6fe 

$ echo '# Comment' >> CHECKSUM 
$ cat CHECKSUM
SHA1 (foo) = 058ab38dd3603703b3a7063cf95dc51a4286b6fe
# Comment

$ cksum --check CHECKSUM
foo: OK

The changes similarly apply to hashsum and its derivatives.

@RenjiSann RenjiSann mentioned this pull request Oct 16, 2024
Closed
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/timeout/timeout is no longer failing!

@RenjiSann
Copy link
Collaborator Author

@BenWiederhake

cakebaker
cakebaker reviewed Oct 17, 2024
View reviewed changes
cakebaker
cakebaker reviewed Oct 17, 2024
View reviewed changes
cakebaker
cakebaker reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great to see more tests :)

@cakebaker cakebaker merged commit 92e67a5 into uutils:main Oct 18, 2024
68 checks passed
@cakebaker
Copy link
Contributor

Thanks :)

@RenjiSann RenjiSann deleted the checksum-comment branch October 18, 2024 12:48
@RenjiSann RenjiSann mentioned this pull request Oct 25, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Nov 16, 2024
Merged
@moonfruit moonfruit mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RenjiSann @cakebaker