Skip to content

clippy: fix clippy warnings #6910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2024
Merged

clippy: fix clippy warnings #6910

merged 2 commits into from
Dec 18, 2024

Conversation

sylvestre
Copy link
Contributor

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre requested review from cakebaker and BenWiederhake and removed request for cakebaker December 4, 2024 09:00
@cakebaker
Copy link
Contributor

Hm, is this PR supposed to fix all warnings from the map_unwrap_or lint? When I run cargo clippy -- -W clippy::map_unwrap_or on the main branch I get warnings in utils like ls and sort and there are no changes to those utils in this PR.

@sylvestre
Copy link
Contributor Author

it fixed the issues that I saw :(
We can fix the rest in a different PR

cakebaker
cakebaker reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I would move the changes made to split and tac to its own commit because they are unrelated to the map_unwrap_or lint. They seem to fix warnings from the needless_as_bytes lint.

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/usage_vs_getopt. tests/misc/usage_vs_getopt is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/basenc/basenc is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit 02eb2c0 into uutils:main Dec 18, 2024
61 of 62 checks passed
@moonfruit moonfruit mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

@BenWiederhake BenWiederhake Awaiting requested review from BenWiederhake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker