Skip to content

seq: handle scientific notation with uppercase 'E' #6928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

artP2
Copy link
Contributor

@artP2 artP2 commented Dec 6, 2024

Fixes #6925.

@sylvestre
Copy link
Contributor

could you please add a test to make sure we don't regress? thanks

@artP2
Copy link
Contributor Author

artP2 commented Dec 6, 2024

Is this enough?

@sylvestre
Copy link
Contributor

almost, please also add an example here: https://github.com/uutils/coreutils/blob/main/tests/by-util/test_seq.rs

@artP2 artP2 force-pushed the scientific-notation-uppercase-E branch from a568a24 to 88e1047 Compare December 6, 2024 21:01
@artP2
Copy link
Contributor Author

artP2 commented Dec 6, 2024

Done

Copy link

github-actions bot commented Dec 6, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@cakebaker cakebaker merged commit f7c38a3 into uutils:main Dec 7, 2024
59 of 62 checks passed
@cakebaker
Copy link
Contributor

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seq: padding of -w is incorrect if scientific notation uses E instead of e
3 participants