Bump clap to 4.5.23 & fix failing seq tests
#6955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
reviewed
Dec 13, 2024
| @@ -47,9 +48,33 @@ struct SeqOptions<'a> { | |||
| /// The elements are (first, increment, last). | |||
| type RangeFloat = (ExtendedBigDecimal, ExtendedBigDecimal, ExtendedBigDecimal); | |||
|
|
|||
| // Turn short args with attached value, for example "-s,", into two args "-s" and "," to make | |||
| // them work with clap. | |||
There was a problem hiding this comment.
maybe add a link to the discussion ?
There was a problem hiding this comment.
Yes, good point, though I will add it to the comment on lines 196/197 where it's a better fit.
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
I guess they are regressions, right? Thanks |
allow_negative_numbers because clap removed support for "exotic" negative numbers like -.1
|
well done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps
clapfrom4.4.2to4.5.23and fixes some failing tests inseqdue to breaking changes inclap's handling of negative numbers. It also adapts two error messages of GNU tests to adapt toclapchanges.