Skip to content

basenc: ignore case with "--base16 --decode" #6963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2024
Merged

basenc: ignore case with "--base16 --decode" #6963

merged 1 commit into from
Dec 17, 2024

Conversation

cakebaker
Copy link
Contributor

Currently, an error is shown if the input provided to basenc --base16 --decode contains lowercase characters. This PR fixes this issue and allows lowercase characters. It also makes the tests b16_9 and b16_10 in basenc.pl pass.

// before change
$ printf "48656c6c6f2c20576f726c6421" | cargo run basenc --base16 -d
basenc: error: invalid input

// after change
$ printf "48656c6c6f2c20576f726c6421" | cargo run basenc --base16 -d
Hello, World!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre merged commit 7c65243 into uutils:main Dec 17, 2024
61 of 62 checks passed
@cakebaker cakebaker deleted the basenc_fix_b16_9_and_10 branch December 17, 2024 10:36
@moonfruit moonfruit mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre