Skip to content

install: implement copying from streams #6965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 29, 2024

Conversation

DaringCuteSeal
Copy link
Contributor

@DaringCuteSeal DaringCuteSeal commented Dec 17, 2024

Resolves:

install now uses the buf-copy module from uucore to do quick data copy under Linux & Android and a buffer-based copy for other OS. FIFOs, character/block devices are considered as streams. Other files still use Rust's fs::copy.

@DaringCuteSeal DaringCuteSeal marked this pull request as draft December 17, 2024 13:42
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

needs to be rebased now :)

@DaringCuteSeal
Copy link
Contributor Author

DaringCuteSeal commented Dec 29, 2024

ok, there. should work.

also, can somebody who can make commits to the main branch delete the last empty doc-comment line over at src/uucore/lib/features/buf_copy/linux.rs at line 61 to make the style check pass? i seem to have missed it because the module has never been used before and i don't think i want to make a PR for that.. please let me know if i should

@DaringCuteSeal DaringCuteSeal marked this pull request as ready for review December 29, 2024 00:32
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Contributor

We have this warning:

error: empty line after doc comment
  --> src/uucore/src/lib/features/buf_copy/linux.rs:61:1
   |
61 | / ///
62 | |
   | |_
63 | / pub fn copy_stream<R, S>(src: &mut R, dest: &mut S) -> UResult<u64>
64 | | where
65 | |     R: Read + AsFd + AsRawFd,
66 | |     S: Write + AsFd + AsRawFd,
   | |______________________________- the comment documents this function
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments

@DaringCuteSeal
Copy link
Contributor Author

We have this warning:

error: empty line after doc comment
  --> src/uucore/src/lib/features/buf_copy/linux.rs:61:1
   |
61 | / ///
62 | |
   | |_
63 | / pub fn copy_stream<R, S>(src: &mut R, dest: &mut S) -> UResult<u64>
64 | | where
65 | |     R: Read + AsFd + AsRawFd,
66 | |     S: Write + AsFd + AsRawFd,
   | |______________________________- the comment documents this function
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments

@sylvestre do I make a new PR or..?

@sylvestre
Copy link
Contributor

add a new commit here :)

@DaringCuteSeal
Copy link
Contributor Author

there

Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 438c3c9 into uutils:main Dec 29, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants