Skip to content

ls: when a file has capabilities (setcap), change the color #6987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2024
Merged

ls: when a file has capabilities (setcap), change the color #6987

merged 2 commits into from
Dec 22, 2024

Conversation

sylvestre
Copy link
Contributor

Should fix tests/ls/capability.sh

Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ls/capability is no longer failing!

1 similar comment
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ls/capability is no longer failing!

Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/ls/capability is no longer failing!

@sylvestre
Copy link
Contributor Author

for some reasons, it didn't mention no-cap.sh
2024-12-22T08:46:25.6573098Z PASS: tests/ls/no-cap.sh

Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ls/no-cap is no longer SKIP! (might be PASS, ERROR or FAIL)
Congrats! The gnu test tests/ls/capability is no longer failing!

@sylvestre
Copy link
Contributor Author

I moved the GNU modification into a different PR:
#6988

Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ls/capability is no longer failing!

…empty ca=

in LS_COLORS

In parallel, in the GNU test, adjust the GNU tests as we don't use libcap
but xattr instead.
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/no-cap is no longer SKIP! (might be PASS, ERROR or FAIL)
Congrats! The gnu test tests/ls/capability is no longer failing!

@cakebaker cakebaker merged commit d3db8dc into uutils:main Dec 22, 2024
62 checks passed
@cakebaker
Copy link
Contributor

Congrats! The gnu test tests/ls/capability is no longer failing!

Great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants