ls: add better support for non-UTF-8 bytes #7020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux + GNU is the OS + userspace least likely to run into issues with such names, both now and in the future.
6979f68 to
3a41272
Compare
|
GNU testsuite comparison: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second commit also enables the tests added here and #6993 on the two linux-gnu targets (I confirmed they pass on Android too, and they should work in MacOS, but GNU is the least likely environment to add anything that would be unhappy with these names).
There's two
FIXMEs added, I'll file issues for them after merging:&str. The comment lists three relevant issues (one, two, three), any one of which would be good enough for our purposes, but I suspect we'll be waiting a while before we see a fix. In the meantime, we match the best we can using lossy conversions; hopefully such sequences are rare in ignore patterns.Gridtype for displaying aligned names also only takes&str. We already use a custom fork, and I suspect we could change the types in a fairly unobtrusive way, so this might be an easy fix. This is rarely observable as a bug though, outside of displaying raw bytes to the terminal (which is an unlikely combination of circumstances).