chroot: fix parsing of --userspec argument #7043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e23f998 to
0f0a242
Compare
|
I need to update the tests to only run |
c05eac7 to
afa61c8
Compare
|
GNU testsuite comparison: |
Fix the parsing of the `--userspec=USER:GROUP` argument so that the both the user and the group are optional, and update the error message to match that of GNU `chroot`. This commit also removes the incorrect `clap` arguments for `--user` and `--group`. In `chroot --user=USER`, the `--user` is an abbreviation of `--userspec`, and in `chroot --group=GROUP`, the `--group` is an abbreviation of `--groups`. Closes uutils#7040.
afa61c8 to
5bd5cdb
Compare
|
GNU testsuite comparison: |
|
I guess you are aware of the remaining issue: |
Yes, there are still a lot of problems with chroot. I'll try to catalog some of them in new issues. Edit: fixed typo: csplit -> chroot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the parsing of the
--userspec=USER:GROUPargument so that the both the user and the group are optional, and update the error message to match that of GNUchroot. This commit also removes the incorrectclaparguments for--userand--group. Inchroot --user=USER, the--useris an abbreviation of--userspec, and inchroot --group=GROUP, the--groupis an abbreviation of--groups.Closes #7040.