Skip to content

echo: add support for POSIXLY_CORRECT #7059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

echo: add support for POSIXLY_CORRECT #7059

merged 1 commit into from
Jan 6, 2025

Conversation

cakebaker
Copy link
Contributor

This PR adds support for the POSIXLY_CORRECT environment variable and should make tests/misc/echo.sh pass.

@cakebaker cakebaker force-pushed the echo_posixly_correct branch from 5a73509 to 256157f Compare January 3, 2025 09:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

GNU testsuite comparison:

GNU test failed: tests/misc/usage_vs_getopt. tests/misc/usage_vs_getopt is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/echo is no longer failing!

@cakebaker
Copy link
Contributor Author

Hm, it looks like it breaks tests/misc/usage_vs_getopt :|

@DaringCuteSeal DaringCuteSeal mentioned this pull request Jan 5, 2025
Merged
@cakebaker cakebaker force-pushed the echo_posixly_correct branch from 256157f to d8d635d Compare January 6, 2025 08:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/cp/cp-i is no longer failing!
Congrats! The gnu test tests/misc/echo is no longer failing!

@cakebaker
Copy link
Contributor Author

I guess the failing of tests/misc/usage_vs_getopt was a false alarm, as I didn't change anything with the latest push (except rebasing).

@sylvestre
Copy link
Contributor

Congrats! The gnu test tests/misc/echo is no longer failing!

excellent!

@sylvestre sylvestre merged commit c201f38 into uutils:main Jan 6, 2025
65 checks passed
@cakebaker cakebaker deleted the echo_posixly_correct branch January 6, 2025 09:23
@moonfruit moonfruit mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre