Skip to content

Conversation

jfinkels
Copy link
Collaborator

@jfinkels jfinkels commented Jan 4, 2025

This fixes the following issue:

$ cargo build -p uu_mkfifo
   Compiling uu_mkfifo v0.0.28 (/home/jeffrey/src/coreutils/src/uu/mkfifo)
error[E0433]: failed to resolve: could not find `mode` in `uucore`
  --> src/uu/mkfifo/src/mkfifo.rs:43:35
   |
43 |         None => 0o666 & !(uucore::mode::get_umask() as usize),
   |                                   ^^^^ could not find `mode` in `uucore`
   |
note: found an item that was configured out
  --> /home/jeffrey/src/coreutils/src/uucore/src/lib/lib.rs:73:26
   |
73 | pub use crate::features::mode;
   |                          ^^^^
note: the item is gated here
  --> /home/jeffrey/src/coreutils/src/uucore/src/lib/lib.rs:72:1
   |
72 | #[cfg(all(not(windows), feature = "mode"))]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0433`.
error: could not compile `uu_mkfifo` (lib) due to 1 previous error

@sylvestre
Copy link
Contributor

I wonder why it hasn't been identified by #7038

@sylvestre sylvestre merged commit 1e8e16b into uutils:main Jan 4, 2025
64 of 65 checks passed
Copy link

github-actions bot commented Jan 4, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@cakebaker
Copy link
Contributor

cakebaker commented Jan 5, 2025

@sylvestre it doesn't show up with util/show-utils.sh and hence it doesn't get tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants